Skip to content

Conversation

@rrrutledge
Copy link
Contributor

This file holds the text to accompany the What Problems Does InnerSource Solve? video.
This accompanying text will appear as a part of the learning path (like this example).

Copy link

@utanapishtim utanapishtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrrutledge rrrutledge changed the title Create problems-solved.md Create introduction/problems-solved.md Nov 28, 2018
@rrrutledge rrrutledge mentioned this pull request Nov 28, 2018
Copy link
Contributor Author

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these great comments, @KathrynKLewis! Tried to incorporate both of them. Let me know how it looks?

@rrrutledge rrrutledge added the Introduction "Introduction" Segments of the Learning Path label Jan 28, 2019
Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document is - as the introduction - clear and concise and represents the video well.

I especially also like the last paragraph starting at line 40 which is not present in the video. Given that this is a valuable addition that is not present in the video (or I missed it), we should make sure that people who focus on the video have a chance to get that, too.
Maybe add a small slide at the end making that visually/non-text available too?

Also, there's a small typo. Thus, request changes for the latter two aspects. Other than that +2 from me as well.


Inner source also provides a general improvement to engineering culture as engineers have the chance to work with a wider variety of new technologies and people.
It facilitates sharing of ideas and solutions across organizational silos.
Developers mentor and learn from one other as they share ideas and solutions across organizational silos.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be 'learn from one another'?
Other than that, 👍.

@rrrutledge
Copy link
Contributor Author

We wrote the last paragraph together after the video was shot. Perhaps when we re-shoot the problems solved video we can re-shoot this one, too.

@rrrutledge rrrutledge merged commit 6d086f2 into InnerSourceCommons:master Feb 12, 2019
@rrrutledge rrrutledge deleted the patch-6 branch February 12, 2019 18:12
Ludmila-N added a commit that referenced this pull request Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Introduction "Introduction" Segments of the Learning Path

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants