-
Notifications
You must be signed in to change notification settings - Fork 47
Create introduction/problems-solved.md #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
utanapishtim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rrrutledge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these great comments, @KathrynKLewis! Tried to incorporate both of them. Let me know how it looks?
lenucksi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document is - as the introduction - clear and concise and represents the video well.
I especially also like the last paragraph starting at line 40 which is not present in the video. Given that this is a valuable addition that is not present in the video (or I missed it), we should make sure that people who focus on the video have a chance to get that, too.
Maybe add a small slide at the end making that visually/non-text available too?
Also, there's a small typo. Thus, request changes for the latter two aspects. Other than that +2 from me as well.
introduction/problems-solved.md
Outdated
|
|
||
| Inner source also provides a general improvement to engineering culture as engineers have the chance to work with a wider variety of new technologies and people. | ||
| It facilitates sharing of ideas and solutions across organizational silos. | ||
| Developers mentor and learn from one other as they share ideas and solutions across organizational silos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be 'learn from one another'?
Other than that, 👍.
|
We wrote the last paragraph together after the video was shot. Perhaps when we re-shoot the |
This file holds the text to accompany the What Problems Does InnerSource Solve? video.
This accompanying text will appear as a part of the learning path (like this example).