Transplant the commit suggestions from #44 onto the principles article. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rrrutledge
approved these changes
May 28, 2019
Contributor
rrrutledge
left a comment
rrrutledge
left a comment
There was a problem hiding this comment.
Thanks, @lenucksi. Sorry to have missed these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 had a few nice changes already in easy-to-apply commit suggestion format that cannot be merged anymore since the #44 is already merged. Thus bringing them up as a PR again. I also resolved the open conversations where the proposed content had already been integrated into master with the conversations remaining open.
Thus, upon merge of this PR all content from the former principles PR would be integrated and the road free for more work on the principles article. @breakbottle