STYLE: Use std::array instead of std::vector for local variables in IO

Declared those variables const when possible.

Author: N-Dekker

Modules/IO/JPEG/src/itkJPEGImageIO.cxx

@@ -20,6 +20,8 @@
 #include "itksys/SystemTools.hxx"
 
 #include "itk_jpeg.h"
+
+#include <array>
 #include <csetjmp>
 
 #define JPEGIO_JPEG_MESSAGES 1
@@ -542,13 +544,11 @@ JPEGImageIO::WriteSlice(const std::string & fileName, const void * const buffer)
   {
     // store the spacing information as pixels per inch or cm, depending on which option
     // retains as much precision as possible
-    std::vector<UINT16> densityPerInch(2);
-    densityPerInch[0] = static_cast<UINT16>(25.4 / m_Spacing[0] + 0.5);
-    densityPerInch[1] = static_cast<UINT16>(25.4 / m_Spacing[1] + 0.5);
+    const std::array<UINT16, 2> densityPerInch{ static_cast<UINT16>(25.4 / m_Spacing[0] + 0.5),
+                                                static_cast<UINT16>(25.4 / m_Spacing[1] + 0.5) };
 
-    std::vector<UINT16> densityPerCm(2);
-    densityPerCm[0] = static_cast<UINT16>(10.0 / m_Spacing[0] + 0.5);
-    densityPerCm[1] = static_cast<UINT16>(10.0 / m_Spacing[1] + 0.5);
+    const std::array<UINT16, 2> densityPerCm{ static_cast<UINT16>(10.0 / m_Spacing[0] + 0.5),
+                                              static_cast<UINT16>(10.0 / m_Spacing[1] + 0.5) };
 
     if (itk::Math::abs(25.4 / m_Spacing[0] - densityPerInch[0]) +
           itk::Math::abs(25.4 / m_Spacing[1] - densityPerInch[1]) <=

Modules/IO/MINC/src/itkMINCImageIO.cxx

@@ -27,6 +27,7 @@
 
 #include "itk_minc2.h"
 
+#include <array>
 #include <memory> // For unique_ptr.
 
 
@@ -481,7 +482,7 @@ MINCImageIO::ReadImageInformation()
 
       double _sep = NAN;
       miget_dimension_separation(m_MINCPImpl->m_MincApparentDims[usableDimensions], MI_ORDER_APPARENT, &_sep);
-      std::vector<double> _dir(3);
+      std::array<double, 3> _dir{};
       miget_dimension_cosines(m_MINCPImpl->m_MincApparentDims[usableDimensions], &_dir[0]);
       double _start = NAN;
       miget_dimension_start(m_MINCPImpl->m_MincApparentDims[usableDimensions], MI_ORDER_APPARENT, &_start);