ENH: Upgrade required Python and CMake version in pyproject.toml #170
Conversation
ITK no longer produced Python 3.8 packages. CMake 3.22.1 is required since InsightSoftwareConsortium/ITK@2fd36ab.
SimonRit
force-pushed
the
cmake_python_versions
branch
from
e9cf59c to
4004803
Compare
|
@hjmjohson I opened this PR following RTKConsortium/ITKCudaCommon#85 |
SimonRit
force-pushed
the
cmake_python_versions
branch
from
46a54e2 to
346bdf1
Compare
|
We also need to update CI from 5.4.2 to 5.4.4 and/or from 6.0a2 to 6.0b1. |
|
Done with 23a9e9f |
SimonRit
force-pushed
the
cmake_python_versions
branch
2 times, most recently
from
b9726c0 to
af29039
Compare
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Thank you. This is a step in the right direction. This update has identified that only Windows wheels get built. The outer project needs to be the more complicated thing due to the need to run the template generation step. We can take clues from the action as to how to update it.
| jobs: | ||
| cxx-build-workflow: | ||
| uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.2 | ||
| uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v6.0b01 |
There was a problem hiding this comment.
This is a template for new remote modules. I don't think we want to point people to a beta version. We should update this to the latest stable, v5.4.4.
There was a problem hiding this comment.
Ok, I wasn't sure. I changed everything to v5.4.4
| itk-python-package-tag: "v6.0b01.post1" | ||
| itk-python-package-org: "InsightSoftwareConsortium" | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
It looks like this file should be updated in a way similar to what was updated in https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/blob/main/.github/workflows/build-test-package-python.yml
There was a problem hiding this comment.
Not if we want to do it for v5.4.4 I guess. Let's see what does the CI say for the new version...
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Ah, you made a push while I was reviewing 😄
SimonRit
force-pushed
the
cmake_python_versions
branch
2 times, most recently
from
2c0edfe to
6a3efdf
Compare
SimonRit
force-pushed
the
cmake_python_versions
branch
2 times, most recently
from
c57fb39 to
7f12288
Compare
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Looks like a great simplification!
SimonRit
force-pushed
the
cmake_python_versions
branch
from
7f12288 to
e0ec2a8
Compare
|
Of course, it should work 😄 |
SimonRit
force-pushed
the
cmake_python_versions
branch
2 times, most recently
from
b928314 to
bcf2ea4
Compare
|
I was testing but I don't see how to use the ITKRemoteModuleBuildTestPackageAction workflow as we need to first execute cookiecutter in the same workflow. Someone more expert in GHA can probably take over... Using ITKRemoteModuleBuildTestPackageAction would be a simplification indeed, otherwise we need to manually sync the current .github/workflow/build-test-package.yml with the ITKRemoteModuleBuildTestPackageAction files. I won't have more time to spend on this and I would suggest to stick to the initial single commit only. |
dzenanz
merged commit fb886e0
into
InsightSoftwareConsortium:main
|
This is a step in the right direction. |
3 participants
ITK no longer produced Python 3.8 packages.
CMake 3.22.1 is required since
InsightSoftwareConsortium/ITK@2fd36ab.