feat(ColorRangeInput): Support smaller step size for float datasets #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
reviewed
Jul 6, 2022
src/Images/ColorRangeInput.jsx
Outdated
| const currentRangeMin = currentRange[0] | ||
| const currentRangeMax = currentRange[1] | ||
|
|
||
| const [step] = useState((currentRange[1] - currentRange[0]) / 200) |
Collaborator
There was a problem hiding this comment.
step is derived from other reactive variables so we can just compute step as a plain variable. No need for useState. We can also put the "isFloat" check here, so step becomes 1 for integer data, simplifying our JSX and avoiding logic repetition.
Collaborator
Author
|
Thank you @PaulHax ! |
thewtex
approved these changes
Jul 7, 2022
Member
|
🔢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Matt McCormick matt.mccormick@kitware.com
Co-authored-by: Paul Elliott paul.elliott@kitware.com