feat(core): tenant-scoped PostgresPlaylistRepository (Phase 1.b.5c)#188
Merged
Conversation
Same pattern as PostgresLibraryRepository — a playlist belongs
directly to a profile (not to a library), so the ownership chain is
`playlist -> profile -> user`, same depth as library. The repo does
NOT implement the single-tenant PlaylistRepository trait — that
surface has no notion of tenancy.
- New profile_id: i64 field on Playlist with #[sqlx(default)] for
cross-backend compatibility. Same pattern as Library.profile_id.
Desktop call site in commands/playlist.rs initializes it to 0
(single-tenant sentinel).
- New postgres/playlist.rs with 5 *_for_profile inherent methods:
- list_for_profile: ORDER BY position ASC, updated_at DESC
(matches the desktop sidebar order)
- get_for_profile: Option<Playlist>, no existence leak
- insert_for_profile: writes a custom playlist (is_smart=0,
smart_rules=NULL, position=0, cover_hash=NULL, cover_is_auto=0
— smart-playlist support isn't on the server yet)
- update_for_profile: UPDATE ... RETURNING with COALESCE
- delete_for_profile: bool
- Counts (track_count, total_duration_ms) projected as 0::bigint
until playlist_track ships on the server.
- cover_path projected as NULL::text (resolved app-side from
cover_hash, same pattern as the desktop SELECT).
Wired in repository/postgres/mod.rs alongside Library + Profile +
Track.
Validated:
- cargo check --workspace --all-targets
- cargo check --features postgres --all-targets (on the core crate
— catches the sqlx Postgres-only path that workspace check misses,
the lesson from #187)
- cargo clippy --features postgres --all-targets -- -D warnings
- cargo test --workspace (passes, no test regression)
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
InstaZDLL
added
scope: backend
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAjout du champ ChangesSupport multi-tenant Postgres pour playlists
Sequence Diagram(s)sequenceDiagram
participant Cmd as create_playlist (command)
participant Repo as PostgresPlaylistRepository
participant PG as PostgreSQL
Cmd->>Repo: insert_for_profile(draft, profile_id, user_id)
Repo->>PG: INSERT ... SELECT ... WHERE EXISTS(profile.id = $profile_id AND profile.user_id = $user_id)
PG-->>Repo: 0 or 1 row
Repo-->>Cmd: Ok(Some(Playlist)) or Ok(None)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src-tauri/crates/core/src/repository/postgres/playlist.rs`:
- Around line 139-182: The INSERT in insert_for_profile creates a playlist with
cover_hash = NULL but sets cover_is_auto = 0, which incorrectly marks a playlist
as having a manual cover; change the SQL in insert_for_profile so the SELECT
uses cover_is_auto = 1 for new playlists with no cover (i.e. set cover_is_auto
to 1 instead of 0 in the INSERT ... SELECT), making the returned Playlist
reflect that no user cover exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 03317c94-fa7e-4771-9ba5-f6a235f75e60
📒 Files selected for processing (4)
src-tauri/crates/app/src/commands/playlist.rssrc-tauri/crates/core/src/domain/playlist.rssrc-tauri/crates/core/src/repository/postgres/mod.rssrc-tauri/crates/core/src/repository/postgres/playlist.rs
CR caught a sticky-flag bug: the previous insert_for_profile wrote cover_is_auto=0 alongside cover_hash=NULL, which incorrectly marks the row as "user uploaded their own cover" — a future server-side auto-cover pipeline would skip it. Desktop convention: - migration `DEFAULT 1` (auto-managed, ready for the auto-cover pipeline) - `commands/playlist.rs::create_playlist` writes `cover_is_auto: 1` - `commands/playlist_cover.rs` flips it to `0` only when the user uploads a manual cover, so the auto-regen path stops touching the row Aligning the Postgres insert with that convention so a freshly created playlist is correctly auto-managed from the start. Doc expanded to call out the rationale + the desktop parity. (Also rewrapped the doc paragraph to avoid a clippy doc_lazy_continuation lint that fired on a stray `+` at the start of a line — markdown was parsing it as a list bullet.) Signed-off-by: InstaZDLL <github.105mh@8shield.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final tier of Phase 1.b.5. A playlist belongs directly to a profile (not nested under library), so the ownership chain is the shorter
playlist → profile → user— same depth as library, different parent. Same design asPostgresLibraryRepository(#185) andPostgresTrackRepository(#186): inherent methods only, noPlaylistRepositorytrait impl on this backend (tenancy would leak through a trait dispatch).Changes
domain/playlist.rs— Newprofile_id: i64field with#[sqlx(default)]for cross-backend compatibility. Desktop call site incommands/playlist.rs::create_playlistinitializes it to0(single-tenant sentinel). Same pattern asLibrary.profile_id.repository/postgres/playlist.rs—PostgresPlaylistRepositorywith 5 inherent*_for_profile(playlist_id, profile_id, user_id)methods:list_for_profile—ORDER BY position ASC, updated_at DESCmatches the desktop sidebar orderget_for_profile—Option<Playlist>, no existence leak across profile / user boundariesinsert_for_profile— writes a custom playlist (is_smart=0, smart_rules=NULL, position=0, cover_hash=NULL, cover_is_auto=0); smart-playlist support isn't on the server yet, it stays in [crate::smart_playlists] consuming the desktop SQLite path until a later phase ports itupdate_for_profile—UPDATE … RETURNING *withCOALESCE, race-free against concurrent deletedelete_for_profile—bool, no-leak blur same as gettrack_count/total_duration_msprojected as0::bigintuntilplaylist_trackships on the server.cover_pathprojected asNULL::text— resolved app-side fromcover_hash, mirrors the desktop SELECT pattern.Test plan
cargo check --manifest-path src-tauri/Cargo.toml --workspace --all-targetscargo check --manifest-path src-tauri/crates/core/Cargo.toml --features postgres --all-targets(the Postgres-feature path the workspace check doesn't activate — lesson from fix(core): inline TrackRow SELECT in postgres list/get methods #187)cargo clippy --manifest-path src-tauri/crates/core/Cargo.toml --features postgres --all-targets -- -D warningscargo test --manifest-path src-tauri/Cargo.toml --workspace(no regression)The Postgres methods themselves get exercised by integration tests in waveflow-server (next PR — 1.b.5c-PR-B).
Refs: RFC-001 §6.5, follows the pattern established by #185, #186.
Summary by CodeRabbit
New Features
Refactor
Chores