feat(sync): wire playlist CRUD enqueue hooks (Phase 1.f.desktop.2b)

[InstaZDLL]

Branches the local sync queue (built in #191) into every playlist mutation command. Once the user signs into a waveflow-server (Phase 1.f.desktop.1 / 1.f.desktop.1b), each CRUD action now appends a matching op to the local `sync_pending_op` log alongside the SQLite write. A future drain task (Phase 1.f.desktop.4) posts these to `/api/v1/sync/ops` and removes the rows the server accepts.

New helper

`crate::sync::hooks::enqueue_op(state, draft)` — single entry point the command handlers call. Returns nothing; every failure is logged via `tracing` and swallowed. Two rationales documented in the module docstring:

1. The user's CRUD operation already succeeded by the time we hit the queue. Aborting would surface a confusing error ("playlist created but…") for what is internally a sync-pipeline hiccup.
2. The future drain task is the right place to detect server-view drift — it can reconcile by `operation_id` and prompt for a full re-sync if the local + server views diverge.

When no `waveflow_server` JWT is stored for the active profile, `enqueue_op` short-circuits without writing. A local-only user never accumulates ops they'll never sync.

Hooks wired

Command	Op shape
`create_playlist`	`op=insert, field=None, payload={name, color_id, icon_id, description?}`
`update_playlist`	One `op=set` per supplied field (name / description / color_id / icon_id), each with its own `lamport_ts`
`delete_playlist`	`op=delete, field=None`
`add_track_to_playlist`	`op=insert, field=tracks, payload={track_ids: [id]}`
`add_tracks_to_playlist`	`op=insert, field=tracks, payload={track_ids: [...]}` (one coalesced op per batch)
`remove_track_from_playlist`	`op=delete, field=tracks, payload={track_ids: [id]}`
`reorder_playlist_track`	`op=set, field=tracks, payload={track_id, position}`
`add_source_to_playlist`	`op=insert, field=tracks, payload={track_ids, via_source}`

Test plan

• `cargo check --workspace`
• `cargo clippy --workspace --all-targets -- -D warnings`
• `cargo fmt -p waveflow --check`
• Manual smoke (requires feat(server-auth): oauth-loopback browser handshake (Phase 1.f.desktop.1b) #190 + waveflow-web feat(player-bar): redesign right cluster (Spotify-style) + overflow defaults #18 deployed):
  • Sign into waveflow-server via Settings → Compte serveur (manual paste OR OAuth loopback)
  • Create a playlist → `sync_get_queue_state` shows `pending_count: 1`
  • Update its name → `pending_count: 2`
  • Add 5 tracks via bulk → `pending_count: 3` (one coalesced op, not five)
  • Reorder a track → `pending_count: 4`
  • Delete the playlist → `pending_count: 5`
  • Sign out, then sign back in to a different account → queue stays per-profile, no cross-tenant contamination

Composition is 4 lines of glue (`read_token` → `lamport::next` → `queue::enqueue`); each brick was individually tested by the 17 unit tests #191 shipped. Dedicated hook-level tests would require constructing a full `AppState` (paths + app_db + active profile + dlna), harder than the integration surface is worth at this scope.

Out of scope (documented in the helper module docstring)

• `commands/library.rs` — folder paths are device-specific. Sync semantics need a design pass before wiring hooks (the server can know about a "library" the user created, but the folder path is per-device — propagating an absolute path is meaningless cross-host).
• `commands/edit.rs` — track tag updates write to the audio file itself; syncing those across devices requires file replication, which isn't part of Phase 1.
• M3U `import_playlist_m3u` — compound op (create + add); kept out so the simple CRUD path stays the reference shape for review.

Summary by CodeRabbit

• Nouvelles Fonctionnalités
  • Synchronisation automatique des modifications de playlists (création, mise à jour, suppression).
  • Synchronisation des contenus de playlists : ajout/suppression de morceaux, ajouts groupés, ajouts via source et réordonnancement.
• Améliorations
  • File de synchronisation renforcée : opérations envoyées en file après chaque changement local, avec gestion des erreurs et comportements sûrs quand une piste n’existe plus.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f832e9eb-981d-4bc1-bb53-c87250cafe39

📥 Commits

Reviewing files that changed from the base of the PR and between 70f2166 and 82359c2.

📒 Files selected for processing (1)

• src-tauri/crates/app/src/commands/playlist.rs

---

📝 Walkthrough

Walkthrough

Cette PR ajoute sync/hooks::enqueue_op (fire-and-forget) et modifie les commandes playlist pour enqueuer, après chaque mutation locale, des PendingOpDraft (insert/set/delete) enrichis d'un timestamp Lamport ; les erreurs d'enqueue sont journalisées puis ignorées.

Changes

Synchronisation des commandes Playlist

Layer / File(s)	Résumé
Module de liaison sync/hooks et export src-tauri/crates/app/src/sync/hooks.rs, src-tauri/crates/app/src/sync/mod.rs	Nouveau module hooks expose enqueue_op en fire-and-forget (erreurs loggées, non propagées). enqueue_op_inner skip si pas de JWT, obtient pool profil, calcule Lamport, appelle queue::enqueue. Ré-exporte PendingOpDraft.
Synchronisation des mutations de playlist (create/update/delete) src-tauri/crates/app/src/commands/playlist.rs (105–124, 172–207, 222–233)	create_playlist enfile insert (payload: name, description, color_id, icon_id). update_playlist enfile un set par champ fourni ({"value": ...}). delete_playlist enfile delete sans payload.
Synchronisation de la gestion des pistes src-tauri/crates/app/src/commands/playlist.rs (311–537)	add_track_to_playlist enfile insert avec track_ids: [track_id]. add_tracks_to_playlist enfile un insert coalescé avec tous track_ids. remove_track_from_playlist enfile delete avec track_ids. reorder_playlist_track lit la position effective puis enfile set avec track_id et position (skip si lecture échoue). add_source_to_playlist enfile insert avec track_ids et via_source (type,id).

Sequence Diagram

sequenceDiagram
  participant Client as CommandePlaylist
  participant Hooks as sync::hooks::enqueue_op
  participant Inner as sync::hooks::enqueue_op_inner
  participant Lamport as sync::lamport
  participant Queue as sync::queue::enqueue

  Client->>Hooks: PendingOpDraft
  Hooks->>Inner: appel async
  alt JWT présent
    Inner->>Lamport: demande timestamp
    Inner->>Queue: enqueue(op + lamport_ts)
  else Pas de JWT
    Inner-->>Hooks: court-circuit (aucun enqueue)
  end
  alt Erreur
    Hooks-->>Hooks: tracing::error! (champs struct)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• InstaZDLL/WaveFlow#191: Introduit la queue sync_pending_op/queue et les types PendingOpDraft / Lamport réutilisés ici.

Suggested labels

size: m

Poem

🎵 Après l'écriture, l'op file en silence,
Lamport marque l'instant, sans vain tumulte.
Fire-and-forget souffle, log en cadence,
Playlists murmurent, la queue exécute.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Le titre respecte Conventional Commits (type et scope en kebab-case) et décrit précisément le changement principal : câblage des hooks d'enqueue pour les mutations de playlists.
Description check	✅ Passed	La description fournit un résumé complet, explique le rationale, documente les hooks câblés avec leurs op shapes, détaille le test plan exécuté, et explicite ce qui reste hors scope.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/1-f-desktop-2b-playlist-enqueue-hooks

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src-tauri/crates/app/src/commands/playlist.rs`:
- Around line 424-441: The sync payload is using the original new_position
rather than the clamped/effective position computed in reorder_track, causing
server replays to disagree with local order; update the call that constructs the
PendingOpDraft inside reorder_track (the crate::sync::hooks::enqueue_op
invocation) to send the clamped/effective position variable (the value after the
clamp logic) as "position" in the payload instead of the input new_position, so
the enqueued op matches the actual local reorder that was applied.
- Around line 105-123: The outbox write (crate::sync::hooks::enqueue_op with
PendingOpDraft) is done in a separate await after committing the local playlist
mutation, so a crash or failure can leave the local change persisted while the
sync op is lost; wrap the playlist mutation and the enqueue_op together in the
same SQLite transaction so they either both commit or both roll back. Modify the
handler in playlist.rs to begin a DB transaction, perform the playlist
insert/update using that transaction, and call a transactional variant of
enqueue_op (or change enqueue_op to accept a &Transaction / transactional
wrapper) so enqueue_op writes into the same transaction; on any error
return/await failure ensure the transaction is rolled back and only commit when
both steps succeed. Ensure the same pattern is applied to the other occurrences
you noted (lines ~179-206, 223-233, 312-322, 346-359, 380-390, 428-441, 482-495)
so playlist mutation and outbox enqueue are atomic.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1f938d2a-6bcc-47d8-acd1-34c1cd569466

📥 Commits

Reviewing files that changed from the base of the PR and between 21b19a2 and 2d018f4.

📒 Files selected for processing (3)

• src-tauri/crates/app/src/commands/playlist.rs
• src-tauri/crates/app/src/sync/hooks.rs
• src-tauri/crates/app/src/sync/mod.rs

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0d7ebb93-98f1-4740-90f7-0c7e54f044dd

📥 Commits

Reviewing files that changed from the base of the PR and between 2d018f4 and 70f2166.

📒 Files selected for processing (2)

• src-tauri/crates/app/src/commands/playlist.rs
• src-tauri/crates/app/src/sync/hooks.rs