Instabug hijacking main thread on Modal open after Instabug 8.4.0

[tedcurrent]

Modal opens have started to lag since instabug-react-native 8.4.0. Reverting to 8.3.4 seems to fix the issue. Please see screenshots and videos below.

Steps to Reproduce the Problem

1. Install instabug-react-native 8.4.0 or newer
2. Add a RN Modal with animation (easiest to use react-native-modal)
3. Open the modal

Expected Behavior

Modal open should animate smoothly.

Actual Behavior

Modal open animation lags (skips frames).

Instabug integration code

SDK Version

"instabug-reactnative": "8.5.4"

React Native, iOS and Android Versions

"react-native": "0.60.4"
iOS 12.4

Device Model

iPhone X and iPhone XS at least.

Diagnostics screenshots

Instabug 8.5.4 (poor perf)

Instabug 8.3.4 (good perf)

Videos demonstrating both scenarios

videos.zip

[AliAbdelfattah]

Thank you for reporting this. We're looking into it.

[AliAbdelfattah]

@tedcurrent, here’s an ad-hoc build of the SDK that has a different method of capturing screenshots for Repro Steps that solves the performance issue you’re facing. Please let us know how this build performs as we are currently testing it out before shipping it to production.

You can install it by running:

npm install --save https://github.com/Instabug/Instabug-React-Native#custom/repro-steps-ios-capture-fix

[tedcurrent]

@AliAbdelfattah Thanks a lot! We'll get to testing this tomorrow! Superb :)

EDIT: I'll come back to this on Monday. Did a quick run and didn't see a big change in performance, but I didn't get any metrics.

[tedcurrent]

@AliAbdelfattah Alright I tested it properly this time. We can still see a slight ~60ms delay in the timing logs, which does cause a small jank, but it's definitely better. It's good to know that we can pinpoint it to repro steps, helps a ton!

Here's a comparison with the adhoc build

Adhoc build (Repro steps enabled):

Adhoc build (Repro steps disabled):

[HeshamMegid]

@tedcurrent thanks a lot for testing it out and for the comparison. We're looking into ways to optimize this even more and for better support for Repro Steps on React Native. As a temporary workaround, you can disable Repro Steps for now.

I'll close this issue for now, but please feel free to reopen it if you need to discuss it more.

[HeshamMegid]

@tedcurrent actually, since we haven't been able to reproduce the slow performance you're getting, it would be really helpful if you could send us a dump of the view hierarchy of the view controller you're presenting that has the performance issue.

You can do this by pausing the Xcode debugger and typing po [[UIWindow keyWindow] recursiveDescription] into the console, or if you prefer, you can take a screenshot of Xcode's view hierarchy view.

[tedcurrent]

@HeshamMegid thanks for committing time to this!

See view hierarchy dump here:
logs.txt

I also noticed from the console that we get this on each modal open:

Instabug: Capture CustomView.
Instabug: Capture CustomView.
Instabug: Capture CustomView.
Instabug: Capture CustomView.
Instabug: Capture CustomView.

So 5 logs on each modal open. This seems to pop up on modals only. Other views don't show such logs.

[HeshamMegid]

@tedcurrent thank you so much! We'll be looking into why this specific view hierarchy is taking a long time to be captured.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.