Potential fix for code scanning alert no. 149: Possibly wrong buffer size in string copy #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size in string copy Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| entry->archive=leak_realloc(entry->archive,strlen(archive)+1); | ||
| strncpy(entry->archive,archive,strlen(archive)+1); | ||
| strcpy(entry->archive,archive); |
Check failure
Code scanning / CodeQL
Unbounded write Critical
|
|
||
| entry->member=leak_realloc(entry->member,strlen(member)+1); | ||
| strncpy(entry->member,member,strlen(member)+1); | ||
| strcpy(entry->member,member); |
Check failure
Code scanning / CodeQL
Unbounded write Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/async-toolkit/security/code-scanning/149
The safest, clearest fix is to replace the calls to
strncpy(..., strlen(...)+1)on lines 123, 126, and 129 withstrcpy(...). This reflects the dynamic allocation that matches the source length, always including the null terminator. We should make this change for all three similar cases for consistency and clarity. No import or further definition changes are required, asstrcpyis already available via<string.h>. Only these lines in the code block need modification.Suggested fixes powered by Copilot Autofix. Review carefully before merging.