-
Notifications
You must be signed in to change notification settings - Fork 4
[hec-assembler]: Automating mem files linking #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
christopherngutierrez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me: File name changes, coding format (remove camel case), documentation, copyright header, import changes, quote characters, new test cases.
Ran test cases on local machine and confirmed to pass.
kylanerace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Accepts multiple mem file inputs to the linker and joins them into one mem file.
Types of changes
What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments