Skip to content

Conversation

@joserochh
Copy link
Contributor

Proposed changes

Accepts multiple mem file inputs to the linker and joins them into one mem file.

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

  • Linker assumes interdependent variables share the same name. Renaming needs to be done in prep.
  • Added ~200 unit tests to linker module, increasing assembler coverage from 20% to 35%.
  • Removed linker folders from pre-commit filter.

@joserochh joserochh marked this pull request as ready for review July 8, 2025 21:33
Copy link
Contributor

@christopherngutierrez christopherngutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: File name changes, coding format (remove camel case), documentation, copyright header, import changes, quote characters, new test cases.

Ran test cases on local machine and confirmed to pass.

Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joserochh joserochh merged commit e21a373 into main Jul 10, 2025
7 checks passed
@joserochh joserochh deleted the joserochh/linking_automation branch July 10, 2025 15:39
@joserochh joserochh changed the title Automating mem files linking [hec-assembler]: Automating mem files linking Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants