Add a static method wait for the SyclEventRaw class
#529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
changed the title
wait for the SyclEventRaw classwait for the SyclEventRaw class
vlad-perevezentsev
force-pushed
the
cython_wait
branch
2 times, most recently
from
81fc629 to
768c6cd
Compare
vlad-perevezentsev
force-pushed
the
refactor/SyclEvent
branch
from
ade7cd6 to
48eeb31
Compare
oleksandr-pavlyk
force-pushed
the
cython_wait
branch
from
768c6cd to
1ed961d
Compare
dpctl/_sycl_event.pyx
Outdated
|
|
||
| @staticmethod | ||
| def wait(event): | ||
| if isinstance(event, list): |
Contributor
There was a problem hiding this comment.
I think this should work even if event is a tuple, or any iterable object of events (need not be a list).
oleksandr-pavlyk
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a static method
waitfor the SyclEventRaw class with a call toDPCTLEvent_WaitAndThrow