-
Notifications
You must be signed in to change notification settings - Fork 23
Add missing dtype aliases #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I would suggest to remove |
fc91b07 to
d3b7d67
Compare
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why we export and dpnp.longcomplex (a.k.a np.complex256) as we do not export dpnp.longdouble (a.k.a. np.float128) and we do not support this data type.
We also do no support np.void, so I suggest we remove dpnp.void too.
Ok, agree. |
|
|
|
All numpy constants ara added to |
The list of missing aliases on numpy types are ported to dpnp:
The flowing type-related functions are added to dpnp:
The following constants are borrowed from numpy:
This PR is intended to resolve issue #1307.