Skip to content

Set dependencies for dpnp_algo Cython extension to account for files involved via use of include #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2023
Merged

Set dependencies for dpnp_algo Cython extension to account for files involved via use of include #1338

merged 3 commits into from
Mar 17, 2023

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Since dpnp_algo.pyx includes a bunch of other .pyx files, build generator needs to be aware of such dependency to correctly perform incremental builds.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@oleksandr-pavlyk
Tweaked compiler options used.
464e140 
Removed linker option -fsycl-device-code-split=per_kernel option
from CFLAGS, added SDL mandated -fwrapv
@oleksandr-pavlyk
Specify dependencies on dpnp_algo on other included pyx files
d653acf
antonwolfy
antonwolfy approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @oleksandr-pavlyk !

@oleksandr-pavlyk oleksandr-pavlyk changed the title Set dependencies Set dependencies for dpnp_algo Cython extension to account for files involved via use of include Mar 16, 2023
@oleksandr-pavlyk oleksandr-pavlyk merged commit e4b900b into master Mar 17, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the set-dependencies branch March 17, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandr-pavlyk @antonwolfy