Skip to content

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 2, 2023

The PR adds a type matrix towards LAPACK pybind11 extension and defines supported type of heevnd and syevd functions by OneMKL.
The existing extensions are updated to call dispatching function depending on type of input arrays.

Additionally the channels are explicitly defined for installing dependent packages of dpnp in generate coverage and build sphinx github actions to prevent unpredictable behavior with defaults channel used by conda-incubator/setup-miniconda (no option provided by the action to override the default channel).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 2, 2023
@antonwolfy antonwolfy marked this pull request as ready for review May 31, 2023 10:58
@antonwolfy antonwolfy requested a review from npolina4 May 31, 2023 10:58
@antonwolfy antonwolfy force-pushed the add_type_dispatch_to_eigh branch 3 times, most recently from 36b66a3 to 1b6a830 Compare May 31, 2023 14:19
@antonwolfy antonwolfy force-pushed the add_type_dispatch_to_eigh branch from 1b6a830 to ce3f603 Compare May 31, 2023 14:21
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @antonwolfy !

@antonwolfy antonwolfy merged commit 8e2c5f7 into IntelPython:master Jun 1, 2023
@antonwolfy antonwolfy deleted the add_type_dispatch_to_eigh branch June 1, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants