Skip to content

Fix generation of coverage in GitHub Action #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 31, 2023
Merged

Fix generation of coverage in GitHub Action #1397

merged 6 commits into from
May 31, 2023

Conversation

vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented May 12, 2023 •
edited
Loading

This PR adds failed tests on CPU to skipped_tests.tbl file and fixes coveralls.exception.CoverallsException: Not on Travis or CircleCI when the coverage report is sent to covealls.io

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this May 12, 2023
antonwolfy
antonwolfy approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev force-pushed the fix_tests branch 7 times, most recently from 2b124d1 to d192e64 Compare May 30, 2023 12:23
@antonwolfy antonwolfy self-requested a review May 30, 2023 16:11
@vlad-perevezentsev vlad-perevezentsev changed the title Update skipeped_tests.tbl Fix generation of coverage in GitHub Action May 30, 2023
@vlad-perevezentsev vlad-perevezentsev merged commit 340ec40 into IntelPython:master May 31, 2023
antonwolfy pushed a commit that referenced this pull request Jun 6, 2023
@vlad-perevezentsev @antonwolfy
Fix generation of coverage in GitHub Action (#1397)
66b2147 
* Update skipeped_tests.tbl
* Use pip install coveralls with pinned version 3.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev @antonwolfy