Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 10, 2025

The PR proposed to add new hooks:

  • pyupgrade to automatically upgrade syntax for newer versions of the language
  • actionlint as a static checker for GitHub Actions workflow files
  • gersemi as a formatter for CMake files

All identified issue from the new hooks have been address here.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 10, 2025
@antonwolfy antonwolfy self-assigned this Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_39 ran successfully.
Passed: 1228
Failed: 1
Skipped: 7

@antonwolfy antonwolfy marked this pull request as ready for review November 10, 2025 12:21
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit b523e9c into master Nov 10, 2025
117 of 119 checks passed
@antonwolfy antonwolfy deleted the extend-pre-commit-hooks branch November 10, 2025 13:52
github-actions bot added a commit that referenced this pull request Nov 10, 2025
The PR proposed to add new hooks:
- [pyupgrade](https://github.com/asottile/pyupgrade) to automatically
upgrade syntax for newer versions of the language
- [actionlint](https://github.com/rhysd/actionlint) as a static checker
for GitHub Actions workflow files
- [gersemi](https://github.com/BlankSpruce/gersemi) as a formatter for
CMake files

All identified issue from the new hooks have been address here. b523e9c
vlad-perevezentsev pushed a commit that referenced this pull request Nov 10, 2025
The PR proposed to add new hooks:
- [pyupgrade](https://github.com/asottile/pyupgrade) to automatically
upgrade syntax for newer versions of the language
- [actionlint](https://github.com/rhysd/actionlint) as a static checker
for GitHub Actions workflow files
- [gersemi](https://github.com/BlankSpruce/gersemi) as a formatter for
CMake files

All identified issue from the new hooks have been address here.
@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2025

Coverage Status

coverage: 81.4%. remained the same
when pulling ef66527 on extend-pre-commit-hooks
into 06d3076 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants