Skip to content

Align erf-like tests with scipy>=0.16.0 #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

Align erf-like tests with scipy>=0.16.0 #2669

merged 1 commit into from
Nov 17, 2025

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 17, 2025 •
edited
Loading

The PR updates a test for erf functions to consider setting DPNP_TEST_ALL_INT_TYPES=1 during the tests run with the latest SciPy installed in the test env.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 17, 2025
@antonwolfy antonwolfy self-assigned this Nov 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_47 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

vlad-perevezentsev
vlad-perevezentsev approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit a408c2a into master Nov 17, 2025
96 checks passed
@antonwolfy antonwolfy deleted the align-tests-with-scipy-0.16.0 branch November 17, 2025 11:04
github-actions bot added a commit that referenced this pull request Nov 17, 2025
@github-actions
Align erf-like tests with scipy>=0.16.0 (#2669)
f684fd4 
The PR updates a test for erf functions to consider setting
`DPNP_TEST_ALL_INT_TYPES=1` during the tests run with the latest SciPy
installed in the test env. a408c2a
@coveralls
Copy link
Collaborator

coveralls commented Nov 17, 2025

Coverage Status

coverage: 81.453%. remained the same
when pulling 808ae24 on align-tests-with-scipy-0.16.0
into 8567fda on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev