Skip to content

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Nov 17, 2025

This PR suggests removing the newshape parameter which is deprecated in dpnp 0.17.0 from dpnp.reshape() to align with NumPy 2.4.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_55 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @vlad-perevezentsev

@coveralls
Copy link
Collaborator

coveralls commented Nov 17, 2025

Coverage Status

coverage: 81.446% (-0.007%) from 81.453%
when pulling 6ce2b4b on remove_newshape
into 0c92fce on master.

@vlad-perevezentsev vlad-perevezentsev merged commit a270259 into master Nov 18, 2025
94 of 96 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the remove_newshape branch November 18, 2025 12:19
github-actions bot added a commit that referenced this pull request Nov 18, 2025
This PR suggests removing the `newshape` parameter which is deprecated
in dpnp 0.17.0 from `dpnp.reshape()` to align with NumPy 2.4. a270259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants