Skip to content

Conversation

@vlad-perevezentsev
Copy link
Contributor

This PR updates the signature of dpnp.reshape by removing None default value for shape argument
and requiring it to be passed explicitly according to Python array API

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2673/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_12 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from remove_newshape to master November 18, 2025 12:19
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 81.45% (+0.003%) from 81.447%
when pulling 56331e2 on require_shape_in_reshape
into 131c490 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants