Improve use of conda-incubator/setup-miniconda GitHub action for Windows jobs.
#121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
jharlow-intel,
ndgrigorian and
xaleryb
as code owners
Collaborator
Seems like we need to correct the windows path for the artifact upload step on the builds. It is no-oping the upload, but passing the build. Then the tests fail to install an artifact and crash |
antonwolfy
force-pushed
the
update-miniconda-gh-action
branch
from
ee5b298 to
0959b23
Compare
Collaborator
Author
|
@jharlow-intel we need to merge that to unblock the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates arguments passed to
conda-incubator/setup-minicondaGitHub action for jobs on Windows OS.It's now asking the latest version of miniforge and to use mamba explicitly.