Implement Series.mean() in new style #219
Conversation
|
|
||
|
|
||
| @overload_method(SeriesType, 'mean') | ||
| def hpat_pandas_series_mean(self, axis=None, skipna=None, level=None, numeric_only=None): |
There was a problem hiding this comment.
| def hpat_pandas_series_mean(self, axis=None, skipna=None, level=None, numeric_only=None): | |
| def hpat_pandas_series_mean(self, axis=None, skipna=True, level=None, numeric_only=None): |
| '{} Unsupported parameters. Given axis: {}, level: {}, numeric_only: {}'.format(_func_name, axis, level, | ||
| numeric_only)) | ||
|
|
||
| def hpat_pandas_series_mean_impl(self, axis=None, skipna=None, level=None, numeric_only=None): |
There was a problem hiding this comment.
| def hpat_pandas_series_mean_impl(self, axis=None, skipna=None, level=None, numeric_only=None): | |
| def hpat_pandas_series_mean_impl(self, axis=None, skipna=True, level=None, numeric_only=None): |
There was a problem hiding this comment.
@shssf could you please explain in this issue #233 for me and all why we should replace Pandas signature skipna=None with our skipna=True?
I really do not understand which criteria I should use to create signature for our functions, which default values I should replace and which to remain. My first suggestion was - do like in Pandas.
There was a problem hiding this comment.
@PokhodenkoSA I would refer to Pandas sources. Please follow signature defined there. Documentation might have a bugs as a regular code. Anyway, by the algo you implemented it is True despite of the fact it None
| else: | ||
| self.assertEqual(actual, expected) | ||
|
|
||
| @unittest.skipIf(hpat.config.config_pipeline_hpat_default, "Series.mean() any parameters unsupported") |
There was a problem hiding this comment.
if hpat.config.config_pipeline_hpat_default is True it has no parameters support?
This parameter is True by default
There was a problem hiding this comment.
It is correct. This test does not work with HPAT pipeline.
Remove mean from HPAD pipeline and add tests Removed commented code Fix tests Rename tests for mean() and test both skipna cases Combine all tests for mean() in one Fix Test list in docstring for mean() implementation Fix for complex numbers and comment mean in series_kernels.py Return mean to series_replace_funcs because it is used in other places Fix docstring for mean Return back mean in _run_call_series and add test for default skipna for old style Improve tests
| '{} Unsupported parameters. Given axis: {}, level: {}, numeric_only: {}'.format(_func_name, axis, level, | ||
| numeric_only)) | ||
|
|
||
| def hpat_pandas_series_mean_impl(self, axis=None, skipna=None, level=None, numeric_only=None): |
There was a problem hiding this comment.
@PokhodenkoSA I would refer to Pandas sources. Please follow signature defined there. Documentation might have a bugs as a regular code. Anyway, by the algo you implemented it is True despite of the fact it None
2 participants
No description provided.