This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Overload Series(StringArraySplitView).str.len() #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssf
reviewed
Dec 2, 2019
| make_attribute_wrapper(StringArraySplitViewType, 'data', '_data') | ||
|
|
||
|
|
||
| class SplitViewStringMethodsType(types.IterableType): |
There was a problem hiding this comment.
How this class related to pandas.core.strings.StringMethods? Why we need it?
There was a problem hiding this comment.
This class related to the pandas string methods through existing unit test:
def test_str_split_filter(self):
def test_impl(df):
B = df.A.str.split(',')
df2 = pd.DataFrame({'B': B})
return df2[df2.B.str.len() > 1]
# ...
where split() returns Series with StringArraySplitView. So I made str.len() to work with such data this way. Otherwise we get something like that:
Invalid store of {{i64, i32*, i32*, {i8*, i8*}, i8*}, i8*, {i8*, i64, i32, i32, i64, i8*, i8*}} to {{i64, i64, i32*, i8*, i8*, i8*}, i8*, {i8*, i64, i32, i32, i64, i8*, i8*}}
Made unique names for string methods types
kozlov-alexey
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.