Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

@Rubtsowa
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Dec 26, 2019

Hello @Rubtsowa! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-28 10:48:16 UTC


@skip_sdc_jit("Series.str.islower is not supported yet")
def test_series_islower_str(self):
series = [['leopard', 'Golden Eagle', 'SNAKE', ''],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use some common data for tests?

Comment on lines 980 to 987
.. code-block:: console
> python ./series/str/series_str_islower.py
0 True
1 False
2 False
3 False
dtype: bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderKalistratov AlexanderKalistratov merged commit ab29690 into IntelPython:master Dec 28, 2019
@Rubtsowa Rubtsowa deleted the add_islower branch April 7, 2020 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants