Update SDC build instruction in Readme.rst #562
Conversation
Merge changes from SDC master
Merge changes from SDC master
Vyacheslav-Smirnov
requested review from
AlexanderKalistratov and
PokhodenkoSA
README.rst
Outdated
| PYVER=<3.6 or 3.7> | ||
| conda create -n SDC -q -y -c numba -c defaults -c conda-forge python=$PYVER numba pandas scipy mpich pyarrow=0.15.1 gcc_linux-64 gxx_linux-64 | ||
| NUMPYVER=<1.16 or 1.17> | ||
| conda create -n SDC -q -y -c numba -c defaults -c intel -c conda-forge python=$PYVER numpy=$NUMPYVER pandas=0.25.3 scipy pyarrow=0.15.1 gcc_linux-64 gxx_linux-64 tbb-devel llvmlite=0.31.0rc1=py*_0 |
There was a problem hiding this comment.
llvmlite is a dependency of numba. Why not remove it from the list?
There was a problem hiding this comment.
We need specific llvmlite version for Numba
There was a problem hiding this comment.
Also here we build numba via setuptools thus need to install its dependencies
There was a problem hiding this comment.
When we will update Numba version we also will have to check new dependencies and modify this line. Is there more convenient way to install numba dependencies?
Also, I think we now could use newer version of llvmlite.
README.rst
Outdated
| # Build Numba | ||
| git clone https://github.com/numpy/numpy.git | ||
| cd numba | ||
| git checkout ef119bcd1733ff49d71bdf2da8a66e91bb704f83 |
There was a problem hiding this comment.
This magic constant is commit number. Could you, please, create variable with name explaining what is specific with this commit?
There was a problem hiding this comment.
Do not think it is required to create a variable for checkouting Numba hash
I just mentioned that
"Intel SDC uses Numba ef119bcd1733ff49d71bdf2da8a66e91bb704f83 commit from master branch as Numba package for build and run.
That is why it is required to build specified Numba first. Build steps are described below."
Do you think there should be described features which we are using?
There was a problem hiding this comment.
This commit is mentioned 3 times. And all of them should be updated after migration to the new one.
README.rst
Outdated
| # Build Numba | ||
| git clone https://github.com/numpy/numpy.git | ||
| cd numba | ||
| git checkout ef119bcd1733ff49d71bdf2da8a66e91bb704f83 |
There was a problem hiding this comment.
This commit is mentioned 3 times. And all of them should be updated after migration to the new one.
README.rst
Outdated
| PYVER=<3.6 or 3.7> | ||
| conda create -n SDC -q -y -c numba -c defaults -c conda-forge python=$PYVER numba pandas scipy mpich pyarrow=0.15.1 gcc_linux-64 gxx_linux-64 | ||
| NUMPYVER=<1.16 or 1.17> | ||
| conda create -n SDC -q -y -c numba -c defaults -c intel -c conda-forge python=$PYVER numpy=$NUMPYVER pandas=0.25.3 scipy pyarrow=0.15.1 gcc_linux-64 gxx_linux-64 tbb-devel llvmlite=0.31.0rc1=py*_0 |
There was a problem hiding this comment.
When we will update Numba version we also will have to check new dependencies and modify this line. Is there more convenient way to install numba dependencies?
Also, I think we now could use newer version of llvmlite.
|
When we updating Numba we should always check the documentation for update. |
|
@PokhodenkoSA ping |
|
@Vyacheslav-Smirnov could you please describe improvements of this PR in PR description? It is not clear for me what is the reason of this PR. |
|
@PokhodenkoSA, PR description updated. |
3 participants
Build instruction in Readme.rst is not reflect to current SDC build process.