This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Initial support of DataFrame.GroupBy by single literal column #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-18 15:55:06 UTC |
kozlov-alexey
force-pushed
the
feature/df_groupby_single_column
branch
from
6525865 to
af914cb
Compare
densmirn
reviewed
Feb 14, 2020
sdc/tests/test_groupby.py
Outdated
| pd.testing.assert_frame_equal(result, result_ref) | ||
|
|
||
| @skip_sdc_jit('Fails with old-pipeline from the start') | ||
| def test_dataframe_groupby_count_by_int(self): |
Contributor
There was a problem hiding this comment.
Maybe to combine tests test_dataframe_groupby_count_by_* via subTest?
sdc/tests/test_groupby.py
Outdated
Comment on lines
161
to
165
| 'A': [2, 1, 2, 1, 2, 2, 1, 0, 3, 1, 3], | ||
| 'B': np.arange(n, dtype=np.intp), | ||
| 'C': np.arange(n, dtype=np.float_), | ||
| 'D': [np.nan, 2., -1.3, np.nan, 3.5, 0, 10, 0.42, np.nan, -2.5, 23], | ||
| 'E': [np.inf, 2., -1.3, -np.inf, 3.5, 0, 10, 0.42, np.nan, -2.5, 23] |
Contributor
There was a problem hiding this comment.
The data is used in a lot of places. Wouldn't you like to move it to some common place?
Contributor
Author
There was a problem hiding this comment.
Yes, you're probably right, I moved it to a global var.
densmirn
reviewed
Feb 14, 2020
Contributor
densmirn
left a comment
densmirn
left a comment
There was a problem hiding this comment.
If you will you could apply above comments in the separate PR.
densmirn
approved these changes
Feb 14, 2020
Collaborator
|
@kozlov-alexey conflicts. |
kozlov-alexey
force-pushed
the
feature/df_groupby_single_column
branch
from
2e3b42c to
49ea6dd
Compare
kozlov-alexey
force-pushed
the
feature/df_groupby_single_column
branch
from
49ea6dd to
62d9b4d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.