This repository was archived by the owner on Feb 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Adding support of pd.RangeIndex for Series and DFs #862
Merged
AlexanderKalistratov
merged 8 commits into
IntelPython:master
from
kozlov-alexey:feature/range_index_support
Jun 24, 2020
Merged
Adding support of pd.RangeIndex for Series and DFs #862
AlexanderKalistratov
merged 8 commits into
IntelPython:master
from
kozlov-alexey:feature/range_index_support
Jun 24, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: 1. Modifies boxing/unboxing of Series and DFs to handle pd.RangeIndex, 2. Adds fix_df_index to transform values of index argumenent of Series and DF ctor calls, which fixes RewriteDataFrame ctor now handling index=None as argument, 3. Adds iteration, operators (is, eq, ne) support for RangeIndexType, 4. Renames and refactors sdc_check_indexes_equal to numpy_like.array_equal, 5. Adds specializations for RangeIndexType in all Series/DF methods, such as operators, getitem, setitem and indexing related functions (sdc_join_series_indexes, sdc_reindex_series, etc).
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-24 12:21:45 UTC |
a26b951 to
120f7ac
Compare
120f7ac to
80f92bc
Compare
densmirn
approved these changes
May 29, 2020
Contributor
Author
|
It seems performance degraded with these changes, need to fix that before merge, e.g. for with #862:
on master:
|
d3bbd8e to
a453d79
Compare
Contributor
Author
|
With reverting back to a separate impl for none (positional) indexes perf stays the same with this PR, see below for Series.operator.add:
on master (e061965):
|
a453d79 to
56e4462
Compare
AlexanderKalistratov
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DF ctor calls, which fixes RewriteDataFrame ctor now handling index=None as argument,
such as operators, getitem, setitem and indexing related functions
(sdc_join_series_indexes, sdc_reindex_series, etc).