This repository was archived by the owner on Feb 2, 2024. It is now read-only.
SAT-2855 - Memory leaks cause segfaults in unit tests #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlov-alexey
requested review from
AlexanderKalistratov,
PokhodenkoSA and
densmirn
densmirn
approved these changes
Jun 16, 2020
AlexanderKalistratov
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issues with leaked Series data/indexes allocated in unit tests and not freed later, due to excessive increfs/missed decrefs. Running the same tests that create series from different inputs multiple times, shows that memory grows without fix and the fix resolves this.