Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

@kozlov-alexey
Copy link
Contributor

This adds a decorator to print Numba compilation stats for a decorated function
and all nested functions (literally all compiled overloads). Filtering
can be made using decorator arguments.

NOTE: this may show a bit lesser times than compile time calculated using
common approach via first_run_exec_time - second_run_exec_time.

@pep8speaks
Copy link

pep8speaks commented Sep 22, 2020

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-10 12:34:39 UTC

This adds a decorator to print Numba compilation stats for a decorated function
and all nested functions (literally all compiled overloads). Filtering
can be made using decorator arguments.

NOTE: this may show a bit lesser times than compile time calculated using
common approach via first_run_exec_time - second_run_exec_time.
@kozlov-alexey kozlov-alexey force-pushed the feature/add_debug_compile_times branch from 95b9f37 to bdfb1e2 Compare September 24, 2020 02:14
@kozlov-alexey
Copy link
Contributor Author

kozlov-alexey commented Sep 25, 2020

Example output (if level=0 arg is used):

Function: csv_reader_py$4
    Pipeline: nopython
    Time: 0.7950319000000032

Function: sdc_pandas_dataframe_drop_impl$34
    Pipeline: nopython
    Time: 2.902112299999988
...

@kozlov-alexey
Copy link
Contributor Author

@Hardcode84 Do you think we can merge this? Some builds are failed due to new pyarrow version, which needs investigation, but this PR is not changing main functionality only adds debug possibilities and is not related to these issues.

@Hardcode84
Copy link
Contributor

Is this critical for us at the moment? I would prefer it to have at least some tests (e.g. run some test in separate process and match output format with regex)

@kozlov-alexey kozlov-alexey force-pushed the feature/add_debug_compile_times branch from f44cdcc to 4413230 Compare September 27, 2020 04:48
@kozlov-alexey
Copy link
Contributor Author

run some test in separate process and match output format with regex

@Hardcode84 I added some tests as you have suggested (haven't done that with separate process though - it seems easier to do this in the same test process).

@kozlov-alexey kozlov-alexey force-pushed the feature/add_debug_compile_times branch from 66c10a9 to c3011f0 Compare October 14, 2020 16:13
@kozlov-alexey kozlov-alexey force-pushed the feature/add_debug_compile_times branch from 4fa5ab8 to 647a598 Compare November 3, 2020 13:03
@kozlov-alexey kozlov-alexey force-pushed the feature/add_debug_compile_times branch from 647a598 to 5436e53 Compare November 6, 2020 12:22
@kozlov-alexey kozlov-alexey merged commit 9deb029 into IntelPython:master Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants