-
Notifications
You must be signed in to change notification settings - Fork 62
Implements init_dataframe as multiple codegen functions #936
Implements init_dataframe as multiple codegen functions #936
Conversation
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-13 15:02:36 UTC |
Motivation: init_dataframe was implemented via Numba intrinsic taking *args, which seems to generate redundant extractvalue/insertvalue LLVM instructions, producing quadratic IR when number of DF columns grows and affecting total compilation time of function that create large DFs. This PR replaces singe init_dataframe with multiple functions basing on number of columns in a DF which are generated at compile time, thus avoiding use of *args.
d2a6b7e to
45bbc80
Compare
|
Test failures of read_csv tests with:
are expected because this PR requires changes from #918 which was rolled-back recently. So this will be blocked until #918 is returned. |
3aaeb48 to
d5863f5
Compare
|
@kozlov-alexey @xaleryb win 3.6 build fails with svml error again: |
7448111 to
473d773
Compare
I think something's wrong with the packages being used (see mkl and many others are installed from public channels, but not built). Can this be a reason? |
Motivation: init_dataframe was implemented via Numba intrinsic taking *args,
which seems to generate redundant extractvalue/insertvalue LLVM
instructions, producing quadratic IR when number of DF columns grows and affecting
total compilation time of function that create large DFs. This PR
replaces singe init_dataframe with multiple functions basing on number of columns
in a DF which are generated at compile time, thus avoiding use of *args.