This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Fix segfault in NRT_dealloc for str_arr getitem #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: legacy SDC implementation copied Numba internals (MemInfo struct and API functions), which if changed on the Numba side (as it's done in IntelPython/Numba where external_allocator is added) may cause segfaults. This PR removes duplication of Numba internals and moves hstr extension to NRT API functions
kozlov-alexey
force-pushed
the
bugfix/str_arr_segfault_nrt
branch
from
b5b3c7c to
cde3c1f
Compare
Hardcode84
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: legacy SDC implementation copied Numba internals (MemInfo
struct and API functions), which if changed on the Numba side (as it's done
in IntelPython/Numba where external_allocator is added) may cause segfaults.
This PR removes duplication of Numba internals and moves hstr extension to
NRT API functions.
Note: numba now will be build dependency for sdc package.