This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Update package wheel #957
Merged
Update package wheel #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vyacheslav-Smirnov
changed the title
|
Hello @Vyacheslav-Smirnov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-17 15:19:19 UTC |
Contributor
Author
|
@kozlov-alexey, I am going to merge these changes. Although wheel package creation is postponed, these changes will be required later. |
Contributor
I don't mind of course, but I would prefer merging it to master (our main dev branch) and from it to gold/2021 (as part of regular drops). |
Contributor
Author
|
Ok, let's do it. I have changed the target branch to master and re executed the CI. |
kozlov-alexey
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.