This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Remove hardcoded dependencies from install instruction #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: installation instruction is often updated at the same time when SDC moves to new version of dependencies, and while building SDC from source works, installing from pre-built binaries might fail since package is uploaded to intel/label/beta only after all validation checks.
AlexanderKalistratov
approved these changes
Apr 2, 2021
kozlov-alexey
added
Ready to merge
[WIP] Work in progress
and removed
Ready for Review
Ready to merge
labels
Contributor
Author
|
Need to verify that pip is working too.. |
Contributor
|
As I remember, these changes "pyarrow=2.0.0 pandas=1.2.0" were added to fix issue when old sdc version is installed instead of fresh because old sdc required less changes in environment then new... |
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-18 11:55:15 UTC |
kozlov-alexey
force-pushed
the
feature/update_readme_install
branch
2 times, most recently
from
4006235 to
9579a6d
Compare
* Fixes pack of failed tests * Skipping floordiv test due to diff behavior in Stock vs Intel numpy
kozlov-alexey
force-pushed
the
feature/update_readme_install
branch
from
9579a6d to
676246f
Compare
kozlov-alexey
force-pushed
the
feature/update_readme_install
branch
from
dd62c47 to
043ac45
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: installation instruction is often updated at the same time
when SDC moves to new version of dependencies, and while building SDC
from source works, installing from pre-built binaries might fail since
package is uploaded to intel/label/beta only after all validation
checks.
Fixes #968