Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

@kozlov-alexey
Copy link
Contributor

@kozlov-alexey kozlov-alexey commented Jul 19, 2021

Motivation: keep up with the latest numba release.

@kozlov-alexey kozlov-alexey added [WIP] Work in progress Waiting other PR This PR depends on functionality to be merged in other PR labels Jul 19, 2021
@kozlov-alexey kozlov-alexey added this to the 0.40 milestone Jul 19, 2021
@kozlov-alexey kozlov-alexey force-pushed the feature/migrate_numba_0.54 branch from 35edfd9 to 01d2ac5 Compare July 26, 2021 13:33
@pep8speaks
Copy link

pep8speaks commented Jul 26, 2021

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-17 22:22:24 UTC

@kozlov-alexey kozlov-alexey modified the milestones: 0.40, gold Aug 16, 2021
@kozlov-alexey kozlov-alexey force-pushed the feature/migrate_numba_0.54 branch from 3d0a490 to 17ab7fe Compare August 16, 2021 18:16
@kozlov-alexey kozlov-alexey force-pushed the feature/migrate_numba_0.54 branch from f97fbba to a8cfe0e Compare August 17, 2021 22:14
@kozlov-alexey kozlov-alexey changed the title [WIP] Preparing for migration to numba=0.54 Preparing for migration to numba=0.54 Aug 17, 2021
@kozlov-alexey kozlov-alexey modified the milestones: gold, 0.40 Aug 17, 2021
@kozlov-alexey kozlov-alexey force-pushed the feature/migrate_numba_0.54 branch from a8cfe0e to 7986ebd Compare August 17, 2021 22:22
@kozlov-alexey
Copy link
Contributor Author

@AlexanderKalistratov, I've just updated to current master and pinned numba==0.54.0 in all files. Hopefully when it's released all checks should pass - they did locally when I checked with 0.54.0rc3, e.g.

FAILED sdc/tests/test_basic.py::TestBasic::test_assert - numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
=================================================== 1 failed, 1257 passed, 477 skipped, 32 xfailed in 290.32s (0:04:50) ====================================================

(and test_assert really passes and fails only when l run it's via pytest -n).

@xaleryb
Copy link
Contributor

xaleryb commented Aug 26, 2021

@AlexanderKalistratov all required checks passed (wheels were deactivated some time ago). Any updates from Numba guys about readiness to publish numba 0.54.0 to conda channel?

@AlexanderKalistratov
Copy link
Collaborator

@xaleryb

Any updates from Numba guys about readiness to publish numba 0.54.0 to conda channel?

Scheduled for next week

@AlexanderKalistratov AlexanderKalistratov changed the base branch from master to gold/2021 August 26, 2021 00:08
@AlexanderKalistratov AlexanderKalistratov merged commit 9702551 into IntelPython:gold/2021 Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Ready for Review Waiting other PR This PR depends on functionality to be merged in other PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants