Skip to content

Create Github Build action instead of DevOps Pipeline #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 28, 2021
Merged

Create Github Build action instead of DevOps Pipeline #180

merged 14 commits into from
Jul 28, 2021

Conversation

BenjaminMichaelis
Copy link
Member

No description provided.

@BenjaminMichaelis BenjaminMichaelis linked an issue Jun 1, 2021 that may be closed by this pull request
Migrate Azure DevOps pipeline to GitHub Action #165
Closed
@BenjaminMichaelis BenjaminMichaelis added the devops Items related to building and deploying label Jun 1, 2021
@BenjaminMichaelis BenjaminMichaelis linked an issue Jun 1, 2021 that may be closed by this pull request
Upgrade build from netcore3.1 to .NET 5.0 #158
Closed
@BenjaminMichaelis BenjaminMichaelis self-assigned this Jun 2, 2021
@BenjaminMichaelis BenjaminMichaelis removed a link to an issue Jun 2, 2021
Upgrade build from netcore3.1 to .NET 5.0 #158
Closed
Keboo
Keboo reviewed Jun 2, 2021
View reviewed changes
@BenjaminMichaelis
Copy link
Member Author

@Keboo testing seems to be failing because it can't find netcoreapp3.1, not sure on the way to get around this since we wanted to use net5.0 and it doesn't seem to like that currently.

@Keboo
Copy link
Member

Keboo commented Jun 4, 2021

@BenjaminMichaelis so it looks like it is the actual running of the test project that is failing. This is because even though the .net5 compiler can be used to compile netcore3.1, it doesn't have the runtime bits to actually execute it. Two options (though I think the first is easier):

  1. Update the test project to be net5 (likely need to update the NuGet packages referenced there too)
  2. Install both .net5 and netcore3.1 (sample here)

@BenjaminMichaelis BenjaminMichaelis linked an issue Jun 9, 2021 that may be closed by this pull request
Upgrade build from netcore3.1 to .NET 5.0 #158
Closed
@BenjaminMichaelis BenjaminMichaelis requested a review from Keboo June 9, 2021 16:18
Keboo
Keboo reviewed Jun 9, 2021
View reviewed changes
MarkMichaelis
MarkMichaelis reviewed Jun 9, 2021
View reviewed changes
@BenjaminMichaelis BenjaminMichaelis removed the request for review from adamskt June 10, 2021 19:23
@adamskt adamskt self-requested a review July 28, 2021 21:31
adamskt
adamskt approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@adamskt adamskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamskt adamskt merged commit 118dbd5 into main Jul 28, 2021
@adamskt adamskt deleted the DevopsToGithubAction branch July 28, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamskt adamskt adamskt approved these changes

@MarkMichaelis MarkMichaelis Awaiting requested review from MarkMichaelis

@Keboo Keboo Awaiting requested review from Keboo

Assignees

@BenjaminMichaelis BenjaminMichaelis

Labels
devops Items related to building and deploying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Azure DevOps pipeline to GitHub Action Upgrade build from netcore3.1 to .NET 5.0
4 participants
@BenjaminMichaelis @Keboo @adamskt @MarkMichaelis