Skip to content

Conversation

BenjaminMichaelis
Copy link
Member

No description provided.

@BenjaminMichaelis
Copy link
Member Author

I am not sure how to put this table in the xml to have the md file generated. Also changes do need to be made to the table for sure but it does create the general structure for the vision

@Keboo
Copy link
Member

Keboo commented Jun 15, 2021

In this case I would not put it in the csharp.md file (since that is generated). Instead I would propose we put it, in its own new md file alongside it, and simply add a link to it from the index.md

@BenjaminMichaelis
Copy link
Member Author

In this case I would not put it in the csharp.md file (since that is generated). Instead I would propose we put it, in its own new md file alongside it, and simply add a link to it from the index.md

Sure, I guess the worry is that it does make that md file less clean with having documents separate (it would be nice to have everything in one place on one page that is related to a topic, ex: c#).

@Keboo
Copy link
Member

Keboo commented Jun 15, 2021

That is true, but that would mean updating the tool to use some sort of templating mechanism. Because this is useful info, my thought would be just to make is a separate file for now and file a follow up issue to update the tool.

@joeriddles
Copy link
Contributor

@BenjaminMichaelis is this ready for review?

@BenjaminMichaelis BenjaminMichaelis marked this pull request as ready for review July 28, 2021 21:33
@BenjaminMichaelis BenjaminMichaelis marked this pull request as draft December 29, 2021 22:51
@BenjaminMichaelis BenjaminMichaelis marked this pull request as ready for review February 9, 2022 01:48
@BenjaminMichaelis BenjaminMichaelis self-assigned this Feb 9, 2022
@BenjaminMichaelis BenjaminMichaelis added the C# coding guidelines Content related to the C# coding guidelines label Feb 9, 2022
@BenjaminMichaelis
Copy link
Member Author

@BenjaminMichaelis is this ready for review?

A bit later... and Now it is!

BenjaminMichaelis and others added 4 commits February 14, 2022 10:12
Minor changes
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md

Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md

Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md

Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md

Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
@BenjaminMichaelis BenjaminMichaelis merged commit 615c27c into IntelliTect:main Feb 14, 2022
@BenjaminMichaelis BenjaminMichaelis deleted the NamingConventionsTable branch February 14, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# coding guidelines Content related to the C# coding guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants