Skip to content

Conversation

kfiroo
Copy link
Contributor

@kfiroo kfiroo commented Aug 23, 2016

only check a refernce to the style exists in the code and not that it is in a style attribute. Fixes #15

…e exists in the code and not that it is in a style attribute
@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage decreased (-7.8%) to 69.838% when pulling c46a3c4 on kfiroo:master into d3d0c32 on Intellicode:master.

@Intellicode
Copy link
Owner

Thanks for your PR! Could you also remove the dead code as result of this change? I can also do it if you like.

@kfiroo
Copy link
Contributor Author

kfiroo commented Aug 25, 2016

@Intellicode I'm on it :)

@FaridSafi
Copy link

+1

@Intellicode
Copy link
Owner

@kfiroo please let me know if there is anything I can help you with

@kfiroo
Copy link
Contributor Author

kfiroo commented Sep 3, 2016

@Intellicode So sorry, my computer decided to drink some vodka so I was "computerless" till now!
I will remove the dead code in the following week as I go over my backlog

@coveralls
Copy link

coveralls commented Sep 10, 2016

Coverage Status

Coverage decreased (-6.5%) to 71.158% when pulling 9697481 on kfiroo:master into d3d0c32 on Intellicode:master.

@sibelius
Copy link

@Intellicode can we merge this please

@Intellicode
Copy link
Owner

@sibelius I guess I missed the additional commits, I'll do it soon!

@Intellicode Intellicode merged commit 4a64cdc into Intellicode:master Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants