Remove bzero macro def and usages. #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
inc/os.h and src/dlpi.c go together and are almost verbatim copies from nfswatch (https://sourceforge.net/projects/nfswatch/files/nfswatch/4.99.11/ last released 2010). While I think it's great to stop using bzero/bcopy (as you note, we don't use bcmp) in our own code, I'm not sure that it's worthwhile cleaning up os.h & dlpi.c, and we don't include os.h in any of our own code. |
waywardmonkeys
force-pushed
the
remove-bzero
branch
from
f005d9f to
eb35874
Compare
Contributor
Author
|
Okay, updated the patch to no longer modify |
waywardmonkeys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just use memset for bzero and we weren't using bcmp at all.