Remove USETIMEFN define. #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, we didn't use `gettimeofday()` on all non-DOS platforms because it wasn't available, so we had to fall back to `time()`. Those days are long gone and we have `gettimeofday()` on all non-DOS platforms. This also removes some code that used `times()` when it used `time()`. This leaves us using `getrusage()` on all non-DOS platforms. This, much like `gettimeofday()`, is now available everywhere. Not all of the fields used here are guaranteed by POSIX, but the ones used here shouldn't be an issue for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we didn't use
gettimeofday()on all non-DOS platformsbecause it wasn't available, so we had to fall back to
time().Those days are long gone and we have
gettimeofday()on all non-DOSplatforms.
This also removes some code that used
times()when it usedtime().This leaves us using
getrusage()on all non-DOS platforms. This,much like
gettimeofday(), is now available everywhere. Not all ofthe fields used here are guaranteed by POSIX, but the ones used
here shouldn't be an issue for now.