REGISTER is for floats. #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to `inc/version.h`, `REGISTER` is for floats which may or may not be able to be in registers due to the `FPTEST` macro implementation. We shouldn't be using it here for non-float data.
nbriggs
approved these changes
Dec 31, 2020
Collaborator
nbriggs
left a comment
nbriggs
left a comment
There was a problem hiding this comment.
LGTM.
I'm thinking that most of the "register" storage class specifications on variables are no longer relevant, since today's compilers seem to ignore them for the most part, except for disallowing taking the address either explicitly or implicitly of such a variable.
Contributor
Author
|
Yes. But I didn't want to do a global change to remove it everywhere yet ... although I do get tempted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
inc/version.h,REGISTERis for floats which mayor may not be able to be in registers due to the
FPTESTmacroimplementation. We shouldn't be using it here for non-float
data.