Skip to content

Conversation

@nbriggs
Copy link
Collaborator

@nbriggs nbriggs commented Feb 23, 2021

Lisp code (WHEELSCROLL) now supports horizontal scrolling on sequences of PAD4 or PAD5 key presses (on the keyset)

This update enables passing mouse button 6 and 7 events through to Lisp on those keys.

@masinter
Copy link
Member

I assume there's a reason to use Button5 + 1 instead of Button6.
Are there accompanying changes to KEYACTION ?

@masinter masinter merged commit 081e228 into master Mar 29, 2021
@nbriggs
Copy link
Collaborator Author

nbriggs commented Mar 29, 2021

@masinter -- X does not have a Button6 or Button7 define, it stops at Button5. However, it produces values Button5+1 and Button5+2 for the two events we are interested in here.

Ron was making changes to KEYACTION when he and I last talked about this. Generally, I'd be happier if you'd approve (if appropriate) a PR, and I'll make sure that any other coordination (such as KEYACTION changes) has happened before I merge it.

@nbriggs nbriggs deleted the enable-horizontal-scroll-buttons branch March 29, 2021 21:54
@masinter
Copy link
Member

That big green "Squash and Merge" button is just too attractive.
I realized after I did it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants