Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations mentioned in #1065
Wip because we want #1058 first
This caches the
MultiAssetIdin memory to avoid unnecessary queries. Thecreate multiasssets.benchmark which focuses on crteating multiassets outputs, shows a remarkable speedup.without caching:
with caching:
This benchmark creates 7000
ma_tx_outentries per block, for 1, 10 and 100 blocks. Allma_tx_outcreated (700000 in the 100 blocks benchmark) reference 700 distinct multiassets.Mainnet has hundrends of millions of
ma_tx_outentries, so I expect some noticeable speedup there. This remains to be checked.Caching can be improved with a LRU cache using https://hackage.haskell.org/package/psqueues to avoid using too much memory for caching all entries.