Improve logs #1104
Closed
Improve logs #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
reviewed
Apr 28, 2022
| then do | ||
| liftIO . logWarning tracer $ mconcat | ||
| [ "validateEpochRewards: rewards spendable in epoch " | ||
| [ "Validate Epoch Rewards: rewards spendable in epoch " |
There was a problem hiding this comment.
That is not actually an improvement. validateEpochRewards is the function name.
erikd
reviewed
Apr 28, 2022
| case eraName of | ||
| Generic.Shelley -> "insertShelleyBlock" | ||
| other -> mconcat [ "insertShelleyBlock(", textShow other, ")" ] | ||
| mconcat ["Insert ", textShow eraName, " Block"] |
There was a problem hiding this comment.
We want the fucntion name not just Insert.
erikd
reviewed
Apr 28, 2022
| { icAddressCache :: !(Map StakeCred DB.StakeAddressId) | ||
| , icPoolCache :: !(Map StakePoolKeyHash DB.PoolHashId) | ||
| } | ||
|
|
There was a problem hiding this comment.
What does this change have to do with improving the logs?
|
@kderme If you want to rebase this branch, the easiest way to do so is to check out |
|
This PR is redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1094