Babbage / Conway PParams JSON serialization

[ch1bo]

Description

This adds JSON deserialization for Babbage and Conway PParams and is an extension of #3949.

• Creates Test.Cardano.Ledger.Core.JSON with a ToJSON -> FromJSON roundtrip

• Fixes the ToJSON instance of BabbagePParams which was missing a protocolVersion

• Adds JSON roundtrip tests to Alonzo, Babbage and Conway PParams.

• Adds protocolVersion also to Conway PParams serialization.

• Updated the golden genesis-conway.json as FromJSON instances are non-derived now and match the ToJSON instances for PoolVotingThresholds and DRepVotingThresholds

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated
• When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
  versioning process.
• The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
• All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
• Code is formatted with fourmolu (use scripts/fourmolize.sh)
• Cabal files are formatted (use scripts/cabal-format.sh)
• hie.yaml has been updated (use scripts/gen-hie.sh)
• Self-reviewed the diff

[lehins]

I think it would be nice to add to Babbage changelog that protocolVersion issue is fixed.

Two issues on CI:

Golden test for ConwayGenesis

The conway-genesis.json need to change, since FromJSON was wrongfully derived for threasholds and you fixed it in the code (thank you!):

{
  "poolVotingThresholds": {
-    "pvtCommitteeNormal": 0,
-    "pvtCommitteeNoConfidence": 0,
-    "pvtHardForkInitiation": 0,
-    "pvtMotionNoConfidence": 0
+    "committeeNormal": 0,
+    "committeeNoConfidence": 0,
+    "hardForkInitiation": 0,
+    "motionNoConfidence": 0
  },
  "dRepVotingThresholds": {
-    "dvtMotionNoConfidence": 0,
-    "dvtCommitteeNormal": 0,
-    "dvtCommitteeNoConfidence": 0,
-    "dvtUpdateToConstitution": 0,
-    "dvtHardForkInitiation": 0,
-    "dvtPPNetworkGroup": 0,
-    "dvtPPEconomicGroup": 0,
-    "dvtPPTechnicalGroup": 0,
-    "dvtPPGovGroup": 0,
-    "dvtTreasuryWithdrawal": 0
+    "motionNoConfidence": 0,
+    "committeeNormal": 0,
+    "committeeNoConfidence": 0,
+    "updateToConstitution": 0,
+    "hardForkInitiation": 0,
+    "ppNetworkGroup": 0,
+    "ppEconomicGroup": 0,
+    "ppTechnicalGroup": 0,
+    "ppGovGroup": 0,
+    "treasuryWithdrawal": 0
  },

CostModels in PParams

We need to adjust how we deal with problematic CostModels, since currently they do not roundtrip. I have an idea on what we can do about this, so I'll submit a separate PR that fixes that.

[ch1bo]

@lehins Fixed the golden genesis-conway file and added changelog entries. I also disabled the Conway PParams JSON roundtrip tests as I do understand that you will fix the that in another PR.

[lehins]

That's perfect. Thank you!