Fix how we update CostModels
#3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/cost-models-fixes
branch
from
05d2cc4 to
6cb680c
Compare
teodanciu
reviewed
Dec 27, 2023
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/CostModels.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
Dec 27, 2023
teodanciu
reviewed
Dec 27, 2023
teodanciu
reviewed
Dec 27, 2023
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Arbitrary.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
Dec 27, 2023
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Binary/CostModelsSpec.hs
Show resolved
Hide resolved
teodanciu
reviewed
Dec 27, 2023
teodanciu
reviewed
Dec 27, 2023
teodanciu
reviewed
Dec 27, 2023
teodanciu
reviewed
Dec 27, 2023
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Binary/CostModelsSpec.hs
Show resolved
Hide resolved
teodanciu
reviewed
Dec 27, 2023
lehins
force-pushed
the
lehins/cost-models-fixes
branch
from
6cb680c to
687a9e4
Compare
…ror` * `Eq` and `Ord` instances were hacky that were going through `Show`, which is unacceptable * `EncCBOR` and `DecCBOR` will be useful later
* Ensure that invalid and Unknown CostModels are removed whenver a new valid CostModel for the language has been added * Stop exporting constructor for the CostModels, thus allowing to enforce invariants * Replace a unit test that checked `applyPPUpdates` with a more comprehensive property test * Add `mkCostModels` and expose `flattenCostModel` * Add `mkCostModelConst`
* Remove `Test.Cardano.Ledger.Alonzo.CostModel` * Add `Cardano.Ledger.Plutus` that re-exports all plutus related functionality * Add a new module for Plutus tests and include one property test
lehins
force-pushed
the
lehins/cost-models-fixes
branch
from
687a9e4 to
da317d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #3953
There are a couple of problems with CostModels in Conway:
CostMododelswas exported thus it was very easy to invalidate invariant that CBOR and JSON instances rely on. Creation and modification ofCostModelsis done with smart constructors and throughMonoidinstanceBesides fixing CostModels this PR also adds more tests and organizes a little bit by removing duplicate functionality
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)