Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Plutus ScriptHash upon execution failure #4030

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Report Plutus ScriptHash upon execution failure #4030

merged 3 commits into from
Feb 5, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Jan 31, 2024 •
edited
Loading

Description

Resolves #3731

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky changed the title Report Plutus ScriptHash upon Report Plutus ScriptHash upon execution failure Jan 31, 2024
@Lucsanszky Lucsanszky force-pushed the lucsanszky/report-plutus-scripthash branch from e366b0e to 5c8f672 Compare February 1, 2024 02:34
@Lucsanszky Lucsanszky force-pushed the lucsanszky/report-plutus-scripthash branch from ccdd3ed to f7371d3 Compare February 1, 2024 16:39
@lehins lehins mentioned this pull request Feb 1, 2024
Merged
9 tasks
@Lucsanszky Lucsanszky force-pushed the lucsanszky/report-plutus-scripthash branch 2 times, most recently from f907120 to 9803910 Compare February 2, 2024 02:44
@Lucsanszky
Copy link
Contributor Author

I will mark this ready for review once #4037 is merged.

@Lucsanszky Lucsanszky force-pushed the lucsanszky/report-plutus-scripthash branch 2 times, most recently from dc2bad0 to 7a21af9 Compare February 2, 2024 17:12
@Lucsanszky Lucsanszky marked this pull request as ready for review February 2, 2024 17:13
lehins
lehins approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thank you!

libs/cardano-ledger-core/CHANGELOG.md Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/Evaluate.hs Show resolved Hide resolved
@Lucsanszky Lucsanszky force-pushed the lucsanszky/report-plutus-scripthash branch from 1f9432d to 26c097d Compare February 5, 2024 13:50
@lehins lehins force-pushed the lucsanszky/report-plutus-scripthash branch from 26c097d to 7c12910 Compare February 5, 2024 15:30
@lehins lehins enabled auto-merge February 5, 2024 15:30
@lehins lehins merged commit 2cf783d into master Feb 5, 2024
11 of 20 checks passed
@neilmayhew neilmayhew deleted the lucsanszky/report-plutus-scripthash branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report Plutus ScriptHash upon execution failure
3 participants
@Lucsanszky @teodanciu @lehins