Add capability to hash Plutus scripts directly
#4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Thanks for adding this! I rebased my branch on top of this and started using the helpers in #4030. LGTM (after conflicts are resolved).
9 tasks
lehins
force-pushed
the
lehins/plutus-hash
branch
from
c3021f5
to
eab28a2
Compare
This change allows us to reliably compute the hash of a `Plutus` script outside of an era specific context. Moreover it simplifies future `EraScript` instance implementation, since all future eras can use `alonzoScriptPrefixTag` for implementing `scriptPrefixTag`
There will never be a need for overwriting the default implemntation of `hashScript` in this class, so it only makes to remove the comment about the dangers of it having a wrong implementation.
lehins
force-pushed
the
lehins/plutus-hash
branch
from
eab28a2
to
686dff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is going to be a useful function for some of the ongoing work #4030 and #4022
Also extract
hashScriptout ofEraScriptclass for improved safetyChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)