Skip to content

RTView: CPU usage (GC + App) as pct, https by default, errors export #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 31, 2022
Merged

RTView: CPU usage (GC + App) as pct, https by default, errors export #3934

merged 6 commits into from
May 31, 2022

Conversation

@denisshevchenko
Copy link
Contributor

Closes #3889. Additionally:

  1. CPU usage (GC/Mut) as percents.
  2. Export errors to JSON-file.
  3. Cleanup (hlint + stylish-haskell + single style of imports).

@denisshevchenko denisshevchenko self-assigned this May 30, 2022
@denisshevchenko denisshevchenko added the RTView The service for monitoring over Cardano nodes label May 30, 2022
@deepfire deepfire force-pushed the issue-3889-https branch from a2582d8 to ab702f8 Compare May 31, 2022 01:49
@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 31, 2022

👎 Rejected by too few approved reviews

@deepfire deepfire marked this pull request as ready for review May 31, 2022 18:00
@deepfire deepfire force-pushed the issue-3889-https branch 2 times, most recently from 3cdbad5 to 080798a Compare May 31, 2022 18:18
@deepfire deepfire force-pushed the issue-3889-https branch from 080798a to 6523fd7 Compare May 31, 2022 18:19
@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 31, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 58bd7e0 into master May 31, 2022
@iohk-bors iohk-bors bot deleted the issue-3889-https branch May 31, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

+1 more reviewer

@deepfire deepfire deepfire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denisshevchenko denisshevchenko

Labels

RTView The service for monitoring over Cardano nodes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RTView: https instead of http

4 participants

@denisshevchenko @deepfire @Jimbo4350