Test generators and shrinkers for snapshot metadata #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small preparatory refactoring, since we'll be importing these test utilities in following commits
We'll use these instances in the new tests that are added by the next commit
jorisdral
force-pushed
the
jdral/test-codec-generators-shrinkers
branch
from
a673675 to
8fe990a
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/test-codec-generators-shrinkers
branch
from
8fe990a to
f182875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote these commits when I was debugging a looping shrinker, but it turned out it was not the shrinkers for metadata that was looping. It was the shrinker for the
Errorstype instead (see fs-sim#84). So even though the new tests in this PR did not find any bugs, we might as well include the tests onmain