Skip to content

feat: hide TableConfig constructor #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

feat: hide TableConfig constructor #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Database/LSMTree.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,15 @@ module Database.LSMTree (
SnapshotLabel (..),

-- * Table Configuration #table_configuration#
TableConfig (..),
TableConfig (
confMergePolicy,
confSizeRatio,
confWriteBufferAlloc,
confBloomFilterAlloc,
confFencePointerIndex,
confDiskCachePolicy,
confMergeSchedule
),
defaultTableConfig,
MergePolicy (LazyLevelling),
SizeRatio (Four),
Expand Down
10 changes: 9 additions & 1 deletion src/Database/LSMTree/Simple.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,15 @@ module Database.LSMTree.Simple (
SnapshotLabel (..),

-- * Table Configuration #table_configuration#
TableConfig (..),
TableConfig (
confMergePolicy,
confSizeRatio,
confWriteBufferAlloc,
confBloomFilterAlloc,
confFencePointerIndex,
confDiskCachePolicy,
confMergeSchedule
),
MergePolicy (LazyLevelling),
SizeRatio (Four),
WriteBufferAlloc (AllocNumEntries),
Expand Down
2 changes: 2 additions & 0 deletions test/Test/Database/LSMTree/StateMachine.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ import qualified Database.LSMTree.Class as Class
import Database.LSMTree.Extras (showPowersOf)
import Database.LSMTree.Extras.Generators (KeyForIndexCompact)
import Database.LSMTree.Extras.NoThunks (propNoThunks)
import qualified Database.LSMTree.Internal.Config as R
(TableConfig (TableConfig))
import Database.LSMTree.Internal.Serialise (SerialisedBlob,
SerialisedValue)
import qualified Database.LSMTree.Internal.Types as R.Types
Expand Down
4 changes: 3 additions & 1 deletion test/Test/Database/LSMTree/StateMachine/DL.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import Control.Tracer
import qualified Data.Map.Strict as Map
import qualified Data.Vector as V
import Database.LSMTree as R
import qualified Database.LSMTree.Internal.Config as R
(TableConfig (TableConfig))
import qualified Database.LSMTree.Model.Session as Model (fromSomeTable, tables)
import qualified Database.LSMTree.Model.Table as Model (values)
import Prelude
Expand Down Expand Up @@ -65,7 +67,7 @@ prop_example =
dl_example :: DL (Lockstep (ModelState R.Table)) ()
dl_example = do
-- Create an initial table and fill it with some inserts
var3 <- action $ Action Nothing $ NewTableWith (PrettyProxy @((Key, Value, Blob))) (TableConfig {
var3 <- action $ Action Nothing $ NewTableWith (PrettyProxy @((Key, Value, Blob))) (R.TableConfig {
confMergePolicy = LazyLevelling
, confSizeRatio = Four
, confWriteBufferAlloc = AllocNumEntries 4
Expand Down