Skip to content

rename: ErrSnapshotNameInvalid -> ErrInvalidSnapshotName #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

rename: ErrSnapshotNameInvalid -> ErrInvalidSnapshotName #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Database/LSMTree/Internal/Paths.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ instance IsString SnapshotName where
fromString = toSnapshotName

data InvalidSnapshotNameError
= ErrSnapshotNameInvalid !String
= ErrInvalidSnapshotName !String
deriving stock (Show)
deriving anyclass (Exception)

Expand Down Expand Up @@ -173,7 +173,7 @@ isValidSnapshotName str =
toSnapshotName :: String -> SnapshotName
toSnapshotName str
| isValidSnapshotName str = SnapshotName str
| otherwise = throw (ErrSnapshotNameInvalid str)
| otherwise = throw (ErrInvalidSnapshotName str)

snapshotsDir :: SessionRoot -> FsPath
snapshotsDir (SessionRoot dir) = dir </> mkFsPath ["snapshots"]
Expand Down
2 changes: 1 addition & 1 deletion src/Database/LSMTree/Internal/Unsafe.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ listSnapshots sesh = do
pure $ catMaybes snaps
where
checkSnapshot hfs root s = do
-- TODO: rethrow 'ErrSnapshotNameInvalid' as 'ErrSnapshotDirCorrupted'
-- TODO: rethrow 'ErrInvalidSnapshotName' as 'ErrSnapshotDirCorrupted'
let snap = Paths.toSnapshotName s
-- check that it is a directory
b <- FS.doesDirectoryExist hfs
Expand Down